Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[permissions] Clarify Compatibility permission's description #130

Merged
merged 3 commits into from Jan 11, 2023

Conversation

Olf0
Copy link
Contributor

@Olf0 Olf0 commented Aug 9, 2022

… as originally suggested at #127 (comment).

@Olf0 Olf0 changed the title Clarify Compatibility permission's description [permissions] Clarify Compatibility permission's description Aug 9, 2022
Copy link
Member

@llewelld llewelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not best-placed to judge (so it'd be good to get a second opinion), but for me this updated wording looks clear and matches my understanding of the permission, so this LGTM.

@attah
Copy link
Contributor

attah commented Aug 9, 2022

A bit of a nitpick... but since we are already here.

README.md Outdated Show resolved Hide resolved
… return from passive ("are provided") to active ("provides").
Copy link
Contributor Author

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llewelld, a soft "ping". 😉

README.md Outdated Show resolved Hide resolved
@pvuorela pvuorela merged commit 958ed89 into sailfishos:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants