Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modes] obs-rpm-build+pp: Move up tools prefix #15

Merged
merged 1 commit into from Jul 29, 2022
Merged

Conversation

Thaodan
Copy link
Contributor

@Thaodan Thaodan commented Jul 16, 2022

If the tools prefix isn't moved up their is a chance that programs which should
be executed under the tools policy is run under the target because the path is
for example in the sbox_user_home.

@martyone
Copy link
Member

I guess the issue you describe may only happen when you are using sb2 directly on host, without the SDK, right? When used under the SDK, tools are always bind-mounted under the unified /srv/ hierarchy specifically to avoid this sort of issues :)

obs-rpm-build (without +pp) does not need this fix? And the other modes? (Haven't checked)

@Thaodan
Copy link
Contributor Author

Thaodan commented Jul 19, 2022

I guess the issue you describe may only happen when you are using sb2 directly on host, without the SDK, right? When used under the SDK, tools are always bind-mounted under the unified /srv/ hierarchy specifically to avoid this sort of issues :)

It depends on where you safe your targets. You can also face the same issue under the SDK if you use sb2 init on a target in home.

obs-rpm-build (without +pp) does not need this fix? And the other modes? (Haven't checked)

obs-rpm-build already has the prefix that this position so doesn't have the issue.

Copy link
Member

@martyone martyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the other modes use this order, then there is no question about :)

I would suggest this message instead: "Fix tools prefix priority"

I would appreciate having a bz item linked here, where I could report time - please create one.

After that it LGTM.

If the tools prefix isn't moved up their is a chance that programs which should
be executed under the tools policy is run under the target because the path is
for example in the sbox_user_home.

Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
@Thaodan Thaodan merged commit 9cc0313 into master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants