[modes] Fix use with tools root explicitly set to host root. JB#58627 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkosola
approved these changes
Aug 31, 2022
Compared to tools_root, tools_prefix is empty when tools_root is empty or "/". This fixes commit c9fb642. The commit aligned tools prefix handling under the obs-rpm-build+pp mode with the other modes, but this broke the case when sb2-init is passed '-t /', which is how it is used on OBS. It seems the obs-rpm-build+pp was tweaked specifically for use with OBS while the other modes have never been used there (since that time). An attempt to ignore the '-t' option when '/' is passed as argument was not successful. Despite the code comments and code branching for the case that tools_root is unset, sb2 fails to load the rule tree in that case. (This might be specific to targets that are not host-compatible. sb2-init used to be used without '-t' under the SDK in case of i486 build targets.)
martyone
changed the title
|
Fixed the commit summary to match the approach finally used. |
Thaodan
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.