Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config.guess and config.sub automatically if needed #19

Merged
merged 1 commit into from Oct 16, 2022
Merged

Conversation

mlehtima
Copy link
Contributor

@mlehtima mlehtima commented Oct 5, 2022

Needed for new autoconf.

@mlehtima mlehtima requested a review from pvuorela October 5, 2022 11:03
@martyone
Copy link
Member

martyone commented Oct 5, 2022

LGTM but #18 needs to be merged or some other fix provided first.

@Thaodan any progress on that front?

@Thaodan
Copy link
Contributor

Thaodan commented Oct 5, 2022 via email

@mlehtima
Copy link
Contributor Author

mlehtima commented Oct 5, 2022

We don't need to add them we can take them from autoconf itself or preffered meego-rpm-config (preffered).

How? A lot of projects have those in the repos

@pvuorela
Copy link

pvuorela commented Oct 5, 2022

Would seem simple enough for me now. Any reason not to merge this?

@pvuorela
Copy link

pvuorela commented Oct 5, 2022

Ok, apparently not working good enough yet would be a reason not to merge :)

@mlehtima mlehtima changed the title [sb2] Add config.guess and config.sub files. JB#58921 Add config.guess and config.sub automatically if needed Oct 5, 2022
@martyone
Copy link
Member

martyone commented Oct 5, 2022

LGTM but #18 needs to be merged or some other fix provided first.

@Thaodan any progress on that front?

@Thaodan any conclusion regarding #18? We need to do something about it before this (or any other PR) can be merged.

@Thaodan
Copy link
Contributor

Thaodan commented Oct 5, 2022 via email

@Thaodan
Copy link
Contributor

Thaodan commented Oct 5, 2022 via email

@pvuorela
Copy link

Yes I'll have a fix next week.

Week nearing its end. The revert PR is small, thus could perhaps consider just having that first to unblock other development?

@mkosola mkosola merged commit 5373beb into master Oct 16, 2022
@mkosola mkosola deleted the jb58921 branch October 16, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants