Add initial code for syscall redirection, fix path lookup failures. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to test this a bit before merging, but seems to work so far. |
krnlyng
changed the title
krnlyng
force-pushed
the
jb55042
branch
8 times, most recently
from
b8d9339
to
4c78b09
Compare
Thaodan
reviewed
Jan 11, 2023
Thaodan
reviewed
Jan 11, 2023
krnlyng
changed the title
Thaodan
reviewed
Jan 11, 2023
preload/syscalls.c
Outdated
| * syscallgate -- syscall() GATE for the scratchbox2 preload library | ||
| * | ||
| * Copyright (C) 2023 Jolla Ltd. | ||
| * Contact: Franz-Josef Haider <franz.haider@jolla.com> |
There was a problem hiding this comment.
I think we should skip adding contact addresses here.
The header misses the license, I would suggest:
*
* SPDX-FileCopyrightText: 2022, Jolla Ltd.
* SPDX-License-Identifier: GPL-2.0
*
There was a problem hiding this comment.
added a header, is it ok like i did it?
There was a problem hiding this comment.
Yeah looks good, we should check the contact address
krnlyng
force-pushed
the
jb55042
branch
11 times, most recently
from
4028239
to
6615f60
Compare
krnlyng
pushed a commit
to krnlyng/qemu-usermode
that referenced
this pull request
Jan 12, 2023
krnlyng
pushed a commit
to krnlyng/qemu-usermode
that referenced
this pull request
Jan 12, 2023
After sailfishos/scratchbox2#21 is merged, we can now let syscalls go through the C syscall function.
krnlyng
changed the title
vigejolla
reviewed
Jan 12, 2023
vigejolla
reviewed
Jan 12, 2023
krnlyng
force-pushed
the
jb55042
branch
2 times, most recently
from
dcf761b
to
d851745
Compare
krnlyng
pushed a commit
to krnlyng/qemu-usermode
that referenced
this pull request
Jan 12, 2023
After sailfishos/scratchbox2#21 is merged, we can now let syscalls go through the C syscall function.
krnlyng
force-pushed
the
jb55042
branch
2 times, most recently
from
03ce75d
to
25414dc
Compare
vigejolla
reviewed
Jan 13, 2023
|
|
||
| #define GET_MACRO(_0,_1,_2,_3,_4,_5,_6,NAME,...) NAME | ||
| #define FOR_EACH(action,...) \ | ||
| GET_MACRO(_0,__VA_ARGS__,EXPAND_6,EXPAND_5,EXPAND_4,EXPAND_3,EXPAND_2,EXPAND_1,EXPAND_0)(action,__VA_ARGS__) |
|
LGTM, except for the "WIP" in title |
krnlyng
pushed a commit
to krnlyng/qemu-usermode
that referenced
this pull request
Jan 13, 2023
After sailfishos/scratchbox2#21 is merged, we can now let syscalls go through the C syscall function.
krnlyng
pushed a commit
to krnlyng/qemu-usermode
that referenced
this pull request
Jan 13, 2023
After sailfishos/scratchbox2#21 is merged, we can now let syscalls go through the C syscall function.
martyone
reviewed
Feb 6, 2023
pathmapping/pathmapping_interf.c
Outdated
| if (asprintf(&virtual_abs_path_at_fd, "%s/%s", dirfd_path, virtual_path) < 0) { | ||
| /* asprintf failed */ | ||
| abort(); | ||
| if (!virtual_path) { |
There was a problem hiding this comment.
!virtual_path || *virtual_path == '\0' would avoid trailing slash in the latter case I think.
krnlyng
changed the title
…uldn't be found for real. JB#59837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.