Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[screen] Update to 4.9.0. Fixes JB#57063 #3

Merged
merged 2 commits into from Oct 11, 2022
Merged

[screen] Update to 4.9.0. Fixes JB#57063 #3

merged 2 commits into from Oct 11, 2022

Conversation

pvuorela
Copy link
Contributor

@pvuorela pvuorela commented Oct 5, 2022

  • Dropped screen-4.7.0-maxstr.patch. Seemed to be coming from Fedora on where such a patch was deleted 2011 already.
  • Disabled braille support which doesn't build properly anymore. There is a patch in Fedora, but then again the screen for mobile device use shouldn't have any need for braille.
  • Switched ncurses dependency to tinfo which is what screen is really using, from same package anyway. Then again doesn't use pkgconfig here, but oh well.
  • Some other spec clean ups included.

@mlehtima @Tomin1

- Dropped screen-4.7.0-maxstr.patch. Seemed to be coming from Fedora
on where such a patch was deleted 2011 already.
- Disabled braille support which doesn't build properly anymore.
There is a patch in Fedora, but then again the screen for mobile
device use shouldn't have any need for braille.
- Switched ncurses dependency to tinfo which is what screen is really
using, from same package anyway. Then again doesn't use pkgconfig
here, but oh well.
- Some other spec clean ups included.
rpm/screen.spec Outdated
@@ -32,20 +31,12 @@ Summary: Documentation for %{name}
Requires: %{name} = %{version}-%{release}
Requires(post): /sbin/install-info
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this here? We have been dropping this from all packages in general.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if we keep the info file then this should be called and guess there was no file trigger added for this.

Alternatively guess we could skip the info file side and just have the man page in the doc package. Suites me.

We haven't been really using this. Man pages should be enough.
@pvuorela pvuorela merged commit ba072cb into master Oct 11, 2022
@mlehtima mlehtima deleted the update_490 branch February 5, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants