New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[harbour-validator] Allow python3dist(pillow). JB#55733 #152
Conversation
| @@ -105,6 +105,7 @@ python3dist(zope-interface) | |||
| python3dist(sortedcontainers) | |||
| python3dist(toml) | |||
| python3dist(twisted) | |||
| python3dist(pillow) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should have a comment here that we take the liberty to update the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. The comments here are not just comments, they are used for generating the documentation (https://docs.sailfishos.org/Develop/Apps/Harbour/Allowed_APIs/#python-support-1). So we would need some special syntax for the comment so that it ends up in the documentation in a nice way. I'll experiment a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment added, and also comment that this is supported since 4.5.0.
|
This is great utility for me in supporting Imageworks, but also for future work on Scribble and Videoworks that's in the pipeline. I've already been testing what was developed with 7.2 with the Jolla 8.x versions and it has been clear sailing! |
We are also upgrading to 9.0.0 before this goes out. There are some incompatible changes, but not too many: https://pillow.readthedocs.io/en/stable/releasenotes/9.0.0.html#backwards-incompatible-changes |
365bb31
to
ba0b464
Compare
|
This is great utility for me in supporting Imageworks, but also for future work on Scribble and Videoworks that's in the pipeline. I've already been testing what was developed with 7.2 with the Jolla 8.x versions and it has been clear sailing!
Looks minimal indeed. Will 9.0.0 be available from Jolla before the 4.4 release or should I try a local build? |
At this stage I can't promise it to be even in 4.4.0, although there are good chances it will get in. |
allowed_requires.conf
Outdated
| @@ -105,19 +105,21 @@ python3dist(zope-interface) | |||
| python3dist(sortedcontainers) | |||
| python3dist(toml) | |||
| python3dist(twisted) | |||
| # While we allow Pillow, we make no quarantees of backwards compatibility between releases. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding to this comment "Supported since Sailfish 4.4.0" or so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment
Please note that even while we allow the Pillow library, we make no quarantees of backwards compatibility. The application developers are responsible for keeping their app compatible when we switch to new major versions of Pillow.
Please note that even while we allow the Pillow library, we make no
quarantees of backwards compatibility. The application developers are
responsible for keeping their app compatible when we switch to new
major versions of Pillow.