Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jb54117 #236

Merged
merged 1 commit into from Apr 30, 2021
Merged

Jb54117 #236

merged 1 commit into from Apr 30, 2021

Conversation

martyone
Copy link
Member

No description provided.

…ixes JB#54117

The original order of zypper invocation becomes an issue when the
capability is also provided by some of the packages installed by
default. In this case `zypper dup --from` choices randomly which of the
locally provided packages should be pulled in and replace the one
available before/by default.
# the output directory as the repos may contain newer packages and
# those would be pulled in preferably. This happens not only when
# working with older sources but also when a package hardcodes
# version in its spec and the --fix-version option is not active.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this seems so logical that I'm starting to wonder if there was some reason (that I'm not aware of and you have already forgotten) why dup was originally performed before install?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seems logical but it feels more natural/safe to dup first and install new packages later - this is what you would normally do to your system, right? In theory, ordered install-first it could fail temporarily and there is the possibility to get a package pulled from a regular repo first and downgraded to the local built version in a second step - harmless but slightly annoying.

Copy link
Member

@vigejolla vigejolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now understand (at least I think so ;) both why we had the order the other way around originally, and why this now fixes the issue. I still think having the possibility to skip the dup entirely wouldn't hurt though...

@martyone
Copy link
Member Author

There is a demand for another feature we discovered yesterday: optionally preinstall additional (not build-required) packages into a temporary snapshot. Optionally == do not fail when they do not exist as they may be provided locally later. Instead of making this a built-in feature of mb2, I would like to add a generic mechanism that would allow freely tweaking the temporary snapshots. This would also allow completely overriding the way build requires all pulled in.

@martyone martyone merged commit 81d9618 into master Apr 30, 2021
@martyone martyone deleted the jb54117 branch April 30, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants