[sdk-assistant] Hide snapshots in the listing unless told otherwise. JB#58916 #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigejolla
reviewed
Oct 10, 2022
| @@ -308,7 +308,7 @@ build target and using the clone to persist the redefined clean state. | |||
|
|
|||
| $ sdk-assistant clone SailfishOS-4.2.0.21-{aarch64,MyDevice} | |||
| $ sdk-assistant maintain SailfishOS-4.2.0.21-MyDevice | |||
| ... add/rm packages etc. ... | |||
| ... add/rm repositories, packages etc. ... | |||
There was a problem hiding this comment.
I would actually leave out packages here. Adding device-specific repositories to the target makes sense, but I think in most cases adding packages should be done in snapshots, as otherwise it might be difficult to return to the clean state. Sure, sometimes it might make sense to add packages to the target, but that should be the exception and not the rule.
There was a problem hiding this comment.
Agreed, you just missed that this particular example is exactly about your suggestion :) See that it clones the (very) original target and uses the clone to define a new clean state by preinstalling adaptation-specific packages (from adaptation-specific repos).
vigejolla
approved these changes
Oct 10, 2022
The '--snapshot' option nowadays only controls how snapshots are selected, so this is not the right place for this kind of information anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.