[mb2] Add '--stable' option to the 'scrape' command. JB#59604 #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigejolla
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Functionalitywise LGTM. I would still consider changing the option to e.g. --keep-filenames. Something that would give a bit more clue about what is going to happen. Yes, it's mentioned in the documentation, but still I would like to have something a bit closer to what actually happens than just "stable", which could mean anything.
|
It was my aim to be generic (and brief) here. The functionality may expand in future and options may be added enable selected features only. E.g. only update patches that really changed or keep the root of the filename but fix the prefix numbers. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.