[init.container] Detect host OS reliably. JB#59670 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /dev tree is now bind-mounted on Linux, so the test for /dev/fuse presence would be true there in most cases too.
Thaodan
reviewed
Jan 12, 2023
| @@ -32,6 +32,15 @@ set -o nounset | |||
| LOG=/var/log/systemboot.log | |||
| NOTE="Autogenerated by $0. Do not edit!" | |||
|
|
|||
| # Backward compatibility with older sfdk - to be dropped later | |||
| if [[ ! ${SAILFISH_SDK_HOST_OS:-} ]]; then | |||
| if [[ -e /dev/fuse ]]; then | |||
There was a problem hiding this comment.
/dev/fuse also exists in Linux. Does docker reveal the target plat form in a another way?
There was a problem hiding this comment.
Yes, on Linux the default content of /dev is different under Docker. This changes now with the related PR under qtc where we bind mount /dev from host.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.