Add sfdk init tests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyone
reviewed
Feb 13, 2023
Comment on lines
55
to
32
| Template Init | ||
| [Template] Build Initialized Project | ||
| qtquick2app qmake ${DEVICE.arch} | ||
| qtquick2app cmake ${DEVICE.arch} | ||
| qtquick2app-qmlonly qmake noarch | ||
|
|
There was a problem hiding this comment.
We should also test build phase separation and shadow builds with cmake etc. So I would rather turn the existing test cases to templates and test those with all combinations of templates and builders. I would use the "Template" suffix to name the templates:
Basic Build
[Template] Basic Build Template
...
Basic Build (Shadow)
[Template] Basic Build (Shadow) Template
...
...
*** Keywords ***
...
Basic Build Template
[Arguments] ...
[Setup] ...
....
[Teardown] ...
...
There was a problem hiding this comment.
Done. Note: For some reason robot does now allow [Setup] in a template - but luckily it's possible to just use the setup keyword directly.
Test both qmake and cmake and also qmlonly Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
martyone
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests so that we can catch these kind of issues automatically in the future