[sensorfwd] Use float values for XYZ data. Fixes JB#60407 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameters are not used on purpose. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
XYZ operator== is used only in unit test code. Due to taking also timestamps into account it is "samples are exactly the same" rather than "sample values are similar enough" type of test - which is unlikely to be useful outside unit testing context. Move the operator from public API header to where it is needed. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
Accelerometer values have granularity of 1 mG even if underlying sensors would report values with higher accuracy. This happens implicitly due to internal to sensorfwd storage using integers for storing xyz vectors. Switch from integers to single precision floating point numbers. Applications that use qtsensors API should work without any changes. Applications that use sensors with xyz data over custom unix socket io channel need to be adapted to data type change. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb60407_accelerometer_pass_through
branch
from
66d61b5
to
532fc4c
Compare
mlehtima
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accelerometer values have granularity of 1 mG even if underlying
sensors would report values with higher accuracy. This happens
implicitly due to internal to sensorfwd storage using integers
for storing xyz vectors.
Switch from integers to single precision floating point numbers.
Applications that use qtsensors API should work without any changes.
Applications that use sensors with xyz data over custom unix socket
io channel need to be adapted to data type change.