core/core.pro: Assure that libsensordatatypes-qt5.so has already been… #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvuorela
reviewed
Jun 13, 2023
sunweaver
force-pushed
the
pr/libsensordatatypes-dependency-fix
branch
from
0733f27
to
f5ce97e
Compare
|
We looked into this a bit deeper and @peat-psuwit came up with a completely different solution addressing the same problem (irregular FTBFSes). |
mlehtima
reviewed
Jun 15, 2023
spiiroin
approved these changes
Aug 8, 2023
|
Thanks @sunweaver ! By any chance would you be able to rebase your PR? |
Having duplicated entry create duplicated rules in Makefile, which seems to confuse Makefile's dependency ordering. To achived intended effect, remove the old entry before adding the new ones.
sunweaver
force-pushed
the
pr/libsensordatatypes-dependency-fix
branch
from
f5ce97e
to
4e73904
Compare
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… built before linking libsensorfw-qt5.so against it.