[sensorfwd] Transfer events from worker threads via pipe #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiiroin
force-pushed
the
jb60382_event_pipe
branch
from
5e67b8b
to
76f3fad
Compare
mlehtima
reviewed
Feb 7, 2024
mlehtima
approved these changes
Feb 7, 2024
jusa
reviewed
Feb 7, 2024
Non-reentrant method HybrisManager::processSample() is used directly from hal worker thread. This can lead to heap corruption and crashes. Use pipe and io-watch for transferring sensor events from worker thread to mainloop context and thus avoid the reentrancy issues by having sensor chain data management happen only in one thread. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb60382_event_pipe
branch
from
76f3fad
to
6dae56c
Compare
Number of events to ask from android hal/service should agree with number of events to transfer over event pipe in one go. Which they do at the moment, but using separately defined hard coded values. Use common maxEvents = 64 constant for both transfer sizes within sensorfwd and from android hal/service. Also harmonize naming of event count variables and parameters. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
mlehtima
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.