Always substract offset regardless of calLevel #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiiroin
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Explanation makes sense -> so does the change.
The class has bunch related member variables that are not explicitly initialized, but at least on a quick glance calLevel != 3 gets all of them assigned. And calLevel is zero initialized. So I guess it is all right too.
mlehtima
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes calibration of the magnetometer. Previously, the subtraction of the offset was being done only when
calLevelwas not3, or any of the offset components needed to be updated. However, even if calibration (i.e. the process of computing the right offsets) is finished, the subtraction must always be done as new raw data keeps going through the filter.This has been tested a while back on the OG PinePhone running Ubuntu Touch 16.04 and it was proposed as part of a PR to the ubports fork of sensorfw. It was suggested there that this is instead sent upstream.