Add PKCE support and also ExtraParams to plugin data #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows sending non-standard query items to server. For example Microsoft identity platform uses this to know that it should prompt user to select account. Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>
Tomin1
changed the title
vigejolla
reviewed
Oct 11, 2022
vigejolla
approved these changes
Oct 11, 2022
Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>
Tomin1
force-pushed
the
jb58703_extra_fields_to_send
branch
from
b428a80
to
9048a89
Compare
vigejolla
reviewed
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ExtraParamsto plugin data. This allows sending non-standard query items to server. For example Microsoft identity platform uses this to know that it should prompt user to select account.This also implements "pixie". It is enabled by default as there should be very little harm if the server does not support it. However, if the service is broken and may not receive
code_challenge, then there isSkipPKCEproperty that can be set to true.There is no support for "plain" method as the specification requires that implementations use "S256" when the device can handle sha256. Server must always support it anyway.
Code challenge is generated just like the specification recommends, constructing 32-octet sequence that is then base64url encoded.