[sp-stress] Ensure builds are reproducible. JB#57224 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Kampas <martin.kampas@jolla.com>
saukko
approved these changes
Aug 16, 2022
Thaodan
reviewed
Aug 16, 2022
| @@ -297,7 +297,7 @@ int main(int argc, const char* argv[]) | |||
| const char *name; | |||
| unsigned int load = 0; | |||
|
|
|||
| printf ("\nCPU load generator, build %s %s.\n", __DATE__, __TIME__); | |||
| printf ("\nCPU load generator\n"); | |||
There was a problem hiding this comment.
You could replace DATE and __TIME__with version which wouldn't change unless the package changes.
There was a problem hiding this comment.
Yeah but is it worth the money? We use RPM, so you rarely need to rely on build metadata embedded in the code. Hence I think it's better to simply drop such info.
Thaodan
reviewed
Aug 16, 2022
| @@ -453,7 +453,7 @@ int main(const int argc, const char* argv[]) | |||
| this_epoch = time(NULL); | |||
| this_pid = getpid(); | |||
| pagesize = (unsigned)getpagesize(); | |||
| printf ("stress paging/swapping load generator, build %s %s\n", __DATE__, __TIME__); | |||
| printf ("stress paging/swapping load generator\n"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.