[timedclient] implement MaximalTimeoutSnoozeCounter #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
previously, and thus, there was no way to actually set this value with timedclient |
pvuorela
reviewed
Aug 11, 2022
tools/timedclient/timedclient.cpp
Outdated
| @@ -1482,6 +1482,10 @@ static void do_add_event(char *args) | |||
| { | |||
| cur_eve.setTimezone(val); | |||
| } | |||
| else if( !strcmp(key, "MaximalTimeoutSnoozeCounter") ) | |||
There was a problem hiding this comment.
Maybe this should start with lower case like other event args?
There was a problem hiding this comment.
+1 (i was copying the info msg, ill change both)
teleshoes
force-pushed
the
master
branch
2 times, most recently
from
7ac1b98
to
5c88630
Compare
pvuorela
reviewed
Aug 12, 2022
tools/timedclient/timedclient.cpp
Outdated
| @@ -881,7 +881,7 @@ static void event_emit_details(CONST Maemo::Timed::Event &eve) | |||
| { | |||
| event_emit_info(eve); | |||
|
|
|||
| printf(" MaximalTimeoutSnoozeCounter: %d\n", | |||
| printf(" maximalTimeoutSnoozeCounter: %d\n", | |||
There was a problem hiding this comment.
I suppose this should stay upper case to be consistent with the below items. Being more kind of "pretty printed" details.
spiiroin
approved these changes
Aug 15, 2022
|
Included in timed >= 3.6.15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.