Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[timed] Moved config files from .timed to .config/timed JB#9228 #4

Merged
merged 1 commit into from
Jan 26, 2023
Merged

[timed] Moved config files from .timed to .config/timed JB#9228 #4

merged 1 commit into from
Jan 26, 2023

Conversation

dsuni
Copy link

@dsuni dsuni commented Jan 20, 2023

Also added code that tries to rename the old config dir to the new one, if new directory does not exist.

[timed] Moved config files from .timed to .config/timed JB#9228
285d07b 
Also added code that tries to rename the old config dir to the new one, if
new directory does not exist.
spiiroin
spiiroin approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@spiiroin spiiroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diagnostlic logging in case of move/create data dir fails might be useful, but as the original did not do that either -> I'll leave adding it up to you. LGTM as it is.

@pvuorela pvuorela merged commit d748c5f into sailfishos:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiiroin spiiroin spiiroin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dsuni @spiiroin @pvuorela