Timezone symlink fix #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tzdata was made to use hardlinks instead of symlinks on JB#52707 due to sandboxing. That broke timed link target check as the inodes remains the same. So instead compare the link target.
Spotted on startup logs: QObject::connect: No such signal dsme_mode_t::mode_reported(const string &) The signatures are matched by strings and "using std" probably confused this enough. Just use the method pointer to avoid any such mismatch.
Tomin1
approved these changes
May 24, 2023
mlehtima
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LaakkonenJussi noticed this earlier while working on connman regulatory domain adjustments.
While at it fixed one "no such signal" error on timed startup.