Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configfs] Add setting for UDC device #13

Merged
merged 1 commit into from Jun 1, 2023
Merged

Conversation

piggz
Copy link
Contributor

@piggz piggz commented May 31, 2023

Volla X23 has 2 UDCs, one being a dummy device. This adds a new setting gadget_udc_device which allows the correct UDC string to be specified. If it is left empty, the old behaviour of reading the UDCs is used.

Copy link
Contributor

@spiiroin spiiroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, couple of cosmetic nits

src/usb_moded-configfs.c Outdated Show resolved Hide resolved
src/usb_moded-configfs.c Outdated Show resolved Hide resolved
src/usb_moded-configfs.c Outdated Show resolved Hide resolved
Volla X23 has 2 UDCs, one being a dummy device.  This adds a new
setting gadget_udc_device which allows the correct UDC string to be
specified.  If it is left empty, the old behaviour of reading the UDCs
is used.
@spiiroin spiiroin merged commit 302cb9e into sailfishos:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants