Revert "Remove devel subpackage" #11
Conversation
This reverts commit dd9305a. It's not useless if you want to make voicecall plugin. It works if voicecall-manager is started without invoker but if you don't link against voicecall and start voicecall-manager with invoker it doesn't load the plugin.
|
mal said to mention that it can't find symbol _ZTI24AbstractVoiceCallHandler |
|
it works! please merge this |
The devel package doesn't include any headers or such. This project doesn't support creating external voicecall plugins. Doing such now would require copying the headers to the plugin project. Also if there are such external hacked plugins, they should keep on working if they were built with the library available and linked against it. If built without it, the build should fail, right? Would be different thing if there were some headers installed. A bit curious on what this external plugin would be. |
|
But creating external plugins work fine just fine since 4.3 or even ealier. The .so file is there, the lack of -devel package just prevents you from linking against it so you have to hack in symlink manually |
|
I wouldn't call it working just fine if the setup involves copying header files from the project. That's a hack. |
|
And whose fault is that :) |
|
Then the solution is not only restoring devel package but adding headers |
|
If you want look at my plugin here you go, i actually just added voicecall as submodule instead of copying headers from nowhere https://github.com/Michal-Szczepaniak/Yottagram/tree/master/YottagramVoicecallPlugin |
Yes. This would make some sense. No guarantees on APIs, of course, but at least it would allow to play with the thing better than with header copies (which git submodule effectively is). |
|
Then please do that after merging this :) |
|
jolla, please merge, this fixes issue you created with 4.5 release for casual users who just want to be able to call in yottagram with sailfish dialer |
|
This also sounds like something we may want to support from within Whisperfish, when I get to implementing voice calls. Is there a place where we can draw inspiration for adding a headers package in here? Of course, official API support is not something I will be asking for any time soon! |
|
I mean adding headers to devel package is simplest thing ever its just matter if jolla wants it or not |
|
Took a while, but there #12 |
|
@pvuorela you have my thanks and love <3 |
|
Merged #12. Closing this. |
This reverts commit dd9305a. It's not useless if you want to make voicecall plugin. It works if voicecall-manager is started without invoker but if you don't link against voicecall and start voicecall-manager with invoker it doesn't load the plugin.
supersedes #10