[xkeyboard-config] Map Xperia 10 III assistant button to camera. JB#60142 #3
Conversation
Yes, and that's ok. We have been just using one mapping to all the devices we've supported. Actually this being the jolla phone mapping here. In theory there could be a collision on the custom keycodes between devices, but in practice new ones are encountered only every few years. And if we'd have different keymaps, we'd need to get more support on configuring one for each device. With a high likelihood of never getting a collision we can just postpone these complication. Thus won't make changes here. |
There was a problem hiding this comment.
But neither the change + associated comment nor the git commit message exactly spells out what is happening / what these numbers are. But that might be just me being unfamiliar with the files in here.
I guess this is all right and turns assistant key to camera key in every device out there - which would be fine by me for now.
…0142 At least Xperia 10 III sends a custom 0x01C9 on the assistant key which is at the same place and in the same form as other devices have a camera key. Thus handling that as camera key now as there is no assistant related functionality here. Nor even clear alternative symbol to map into.
pvuorela
force-pushed
the
assistant_button
branch
from
7ac8cd9
to
cfc5581
Compare
|
Added a few words to the commit message. |
Needs also mer-hybris/droid-hal-configs#258