[graphics] Put the dummy drm init+exit step back in. JB#59812 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Xperia 10 yamui works when tested after bootup, but shows blank screen when used for bootup splash screen (as the real intent is). So, apparently that dummy drm init+exit that got removed in refactoring is after all needed for some devices and needs to be put back in. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
For example partially successful gr_init() call can call gr_exit() before gr_backend has been set to non-null value. Check that gr_backend has non-null value before use. While at it, check also that gr_vt_fd has actually been opened. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
Failing gr_init() call can leave dynamic resources behind and these are not released unless gr_exit() is called. Ensure that yamui does not skip gr_exit() on gr_init() failure Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
Should be: Indent by 8 and use leading tabs. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
mkosola
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[yamui] Normalize indentation
Should be: Indent by 8 and use leading tabs.
[yamui] Call gr_exit() even if gr_init() fails
Failing gr_init() call can leave dynamic resources behind
and these are not released unless gr_exit() is called.
Ensure that yamui does not skip gr_exit() on gr_init() failure
[graphics] Fix potential null deref in gr_exit()
For example partially successful gr_init() call can call gr_exit()
before gr_backend has been set to non-null value.
Check that gr_backend has non-null value before use.
While at it, check also that gr_vt_fd has actually been opened.
[graphics] Put the dummy drm init+exit step back in. JB#59812
In Xperia 10 yamui works when tested after bootup, but shows blank
screen when used for bootup splash screen (as the real intent is).
So, apparently that dummy drm init+exit that got removed in refactoring
is after all needed for some devices and needs to be put back in.