[yamui] Add skip display cleanup option and drop --debug. JB#60712 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiiroin
requested changes
May 31, 2023
|
@spiiroin Better? |
LaakkonenJussi
changed the title
LaakkonenJussi
changed the title
spiiroin
approved these changes
Jun 1, 2023
The --debug option may be misleading as it would also do the display cleanup at quitting. The display cleanup is set to be executed always and thus, a new option to skip the cleanup is added: --skip-cleanup/-c. On some devices the cleanup is not needed but on some this gives benefit of progressing the VT status changes appropriately in order to systemd logind to function correctly in every case.
spiiroin
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --debug option may be misleading as it would also do the display
cleanup at quitting. The display cleanup is set to be executed always
and thus, a new option to skip the cleanup is added: --skip-cleanup/-c.
On some devices the cleanup is not needed but on some this gives
benefit of progressing the VT status changes appropriately in order to
systemd logind to function correctly in every case.