[yamuisplash] Adapt to yamui changes. Fixes JB#59812 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiiroin
commented
Jan 28, 2023
Thaodan
reviewed
Jan 28, 2023
|
Simo Piiroinen ***@***.***> writes:
> EnvironmentFile=-/var/lib/environment/compositor/*.conf
-ExecStart=/bin/sh /usr/bin/yamuisplash
-# make sure we run for at least 5 seconds for any touch initialization sequences to finish.
-ExecStartPost=/bin/sleep 5
+ExecStartPre=/bin/touch /tmp/.yamuisplash.done
Possibly. Did not think about it, just tweaked where it does what it
already did. But this is executed quite early in bootup -> is /run
already ready for use? And if it is, where/how should this /run/yamui
directory be created?
/run is available after the rootfs is mounted. /run/yamui can be created
with tmpfiles.d or `RuntimeDirectory` inside yamui.service.
|
So, actually /run is available a bit earlier than /tmp - which means using it would be a good thing. I think tmpfiles.d is out because waiting for systemd-tmpfiles-setup.service would incur about 2 second delay for showing the splascreen. RuntimeDirectory should work (but given the purpose, needs RuntimeDirectoryPreserve=yes too). Need to test that (and dropping flagfile use altogether too). |
spiiroin
commented
Jan 30, 2023
spiiroin
force-pushed
the
jb59812_compositor_extension
branch
from
b521155
to
3e936ac
Compare
|
Review commits squashed |
mkosola
approved these changes
Feb 7, 2023
Yamui has been modified so that it is systemd aware and implements compositor D-Bus service. Switch yamuisplash systemd service type from simple to notify, and remove the not really necessary start script. As yamui will now automatically exit when the next UI wants to take over display, systemd drop-ins that were used for explicitly stopping splashscreen service can be removed. Move flagfile from /tmp to /run and remove After=tmp.mount. Add Conflicts/Before=shutdown.target as is recommended for services that utilize DefaultDependencies=no. As yamui gets executed and grabs display well before droid hal init has a chance to start android hw composer, there is no need for explicit delay and thus Before=droid-hal-init.service can be removed. However, in order to ensure deterministic display ownership transfer, unlock agent and user session need to wait until yamui is ready. Uses features that are available in yamui >= 1.2.0 Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb59812_compositor_extension
branch
from
3e936ac
to
8d6ff57
Compare
|
Removed Before=droid-hal-init.service |
mkosola
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yamui has been modified so that it is systemd aware and implements compositor D-Bus service.
Switch yamuisplash systemd service type from simple to notify, and remove the not really necessary start script.
As yamui will now automatically exit when the next UI wants to take over display, systemd drop-ins that were used for explicitly stopping splashscreen service can be removed.
Signed-off-by: Simo Piiroinen simo.piiroinen@jolla.com