Repository navigation
Video processing fails with 0.8.0 #110
Description
Hi,
after upgrading to 0.8.0 i found that unfortunately sigal fails while processing a video. With 0.7.0 everything just worked fine.
here the stacktrace:
.ERROR: Failed to process /home/pi/gallery/pictures/Valencia 2013/CIMG4433.AVI
ERROR: Failed to process /home/pi/gallery/mygallery/Valencia 2013/CIMG4433.webm
Traceback (most recent call last):
File "/usr/local/bin/sigal", line 9, in <module>
load_entry_point('sigal==0.8.0', 'console_scripts', 'sigal')()
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 609, in __call__
return self.main(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 589, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 935, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 781, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 416, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/sigal/__init__.py", line 133, in build
gal.build(force=force)
File "/usr/local/lib/python2.7/dist-packages/sigal/gallery.py", line 528, in build
processor(files)
File "/usr/local/lib/python2.7/dist-packages/sigal/gallery.py", line 581, in process_file
return process_video(src_path, dst_path, settings)
File "/usr/local/lib/python2.7/dist-packages/sigal/video.py", line 152, in process_video
fit=settings['thumb_fit'], options=settings['jpg_options'])
File "/usr/local/lib/python2.7/dist-packages/sigal/video.py", line 130, in generate_thumbnail
check_subprocess(cmd, source, outname)
File "/usr/local/lib/python2.7/dist-packages/sigal/video.py", line 55, in check_subprocess
os.remove(outname)
OSError: [Errno 2] No such file or directory: '/home/pi/gallery/mygallery/Valencia 2013/thumbnails/CIMG4433.jpg'
Activity
sebiii commentedon Sep 5, 2014
Apparently the video was ignored in 0.7.0 (the video is in Motion JPEG format). Is there a plan to support this format? or can the video be also ignored in 0.8?
saimn commentedon Sep 7, 2014
Hi @sebiii
Before 0.8.0, if the ffmpeg subprocess failed or was interrupted, it was failling silently, and could have created an output file which was not desirable (see #90). So I added a line of code to remove this file, without checking that the file actually exists, which is bad :s. So I will add a check for this.
Concerning the MJPEG support, I don't see why it should work but I haven't tested. Can you run sigal in debug mode (
-d) and paste the output to see where it is failing ?sebiii commentedon Sep 8, 2014
hi @saimn ,
thank you for the answer! Unfortunately, sigal still fails when trying to open the temporary tumbnail file (see trace below). I have also attached the output of sigal in debug mode.
Check that the file exists before removing. (fix saimn#110)
saimn commentedon Sep 9, 2014
Are you sure you have updated the code with the master branch from github ? I can't reproduce it, but I have added an extra check in 6997209. Please check if it is better now.
sebiii commentedon Sep 10, 2014
Dear @saimn ,
I have tested the code with the extra check and it now skips the videos just fine, but seems to fail in the end at the zip generation (i have zip_media_format = 'resized').
saimn commentedon Sep 11, 2014
Ah yeah, if the video have not been generated they can't be used in the zip process ... I will also add a check there. The main issue is that currently the failed images/videos are not removed from the list of files of an album, I must to look at this.
Skip files that don't exist in the ZIP archiving (ref #110).
saimn commentedon Sep 15, 2014
@sebiii : I have added the check, can you test again to see if it is ok ? Thanks.
sebiii commentedon Sep 16, 2014
Dear @saimn ,
the build process now exits without errors, but I have the videos in my gallery as items (which obviously cannot be played).
saimn commentedon Sep 16, 2014
Yeah, currently the solution is to remove these files from the source directory, but I will try to find a better solution. It was on my todo list but I have created an issue to track this (#112). Thanks for your help on tracking these failures !