Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 3gp #226

Closed
pmlopes opened this issue Dec 27, 2016 · 5 comments
Closed

add support for 3gp #226

pmlopes opened this issue Dec 27, 2016 · 5 comments
Milestone

Comments

@pmlopes
Copy link

@pmlopes pmlopes commented Dec 27, 2016

This is a video format common on some Android devices and supported by ffmpeg so I guess it could be easily added to sigal.

@saimn
Copy link
Owner

@saimn saimn commented Jan 2, 2017

Do you mean in input or output ?
As an output format, I don't think 3gp is supported by the <video> tag.
As input, every format that is supported by ffmpeg should already be supported, and will be converted to webm or mp4.

@pmlopes
Copy link
Author

@pmlopes pmlopes commented Jan 3, 2017

Sorry for the confusion, I mean input only. The fix is easy as add the extension to two places.

@saimn
Copy link
Owner

@saimn saimn commented Jan 3, 2017

Ah yes indeed, it should be added to the list of extensions.

@saimn saimn closed this in 1f63429 Jan 3, 2017
@saimn
Copy link
Owner

@saimn saimn commented Jan 3, 2017

@pmlopes - Done, if you want to test.

@saimn saimn added this to the 1.3.0 milestone Jan 3, 2017
@pmlopes
Copy link
Author

@pmlopes pmlopes commented Jan 4, 2017

Works 👍

kontza pushed a commit to kontza/sigal that referenced this issue Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.