New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transparent info box? #308

Closed
anarcat opened this Issue Mar 6, 2018 · 7 comments

Comments

2 participants
@anarcat
Contributor

anarcat commented Mar 6, 2018

what would be the best way to make the background color on the galleria infobox transparent?

I'd like to turn this:

image

into that:

image

I did this by changing the background-color on the galleria-info-text element to rgb(0,0,0,0.5) (instead of #000) but I am not sure I want to hack at the galleria theme directly...

@saimn

This comment has been minimized.

Owner

saimn commented Mar 6, 2018

Not sure if this should be changed on the default style as it could be less readable on more white images ?
And currently there is no way to customize easily a theme, other than using a modified copy. But that would certainly be a useful feature, we could have a user_css setting to point to a file that would be loaded on each theme, to allow easy customization like this that can be done in pure css.

@anarcat

This comment has been minimized.

Contributor

anarcat commented Mar 6, 2018

well, it's "black with transparent background", so presumably it would still work white dimmer images...

a user_css would certainly be useful, and yeah, maybe i just need to take this upstream to galleria, shouldn't i? :)

@saimn

This comment has been minimized.

Owner

saimn commented Mar 6, 2018

well, it's "black with transparent background", so presumably it would still work white dimmer images...

yes, maybe, but it's something t check. If it gives good results, I'm fine with integrating this change in the default style (in sigal).

a user_css would certainly be useful, and yeah, maybe i just need to take this upstream to galleria, shouldn't i? :)

It would be useful for all themes in sigal, so that's really something to do on our side I think.

@anarcat

This comment has been minimized.

Contributor

anarcat commented Mar 6, 2018

okay then, here's how it looks like with a (mostly) white background:

image

LGTM. :)

@saimn

This comment has been minimized.

Owner

saimn commented Mar 6, 2018

The contrast seems too poor to me (see below), it could work with alpha 0.8 but is it enough transparent for you ?

capture d ecran de 2018-03-07 00-39-02

With 0.8:
capture d ecran de 2018-03-07 00-44-14

@anarcat

This comment has been minimized.

Contributor

anarcat commented Mar 7, 2018

sure, as long as there's some transparency...

(wow, that's a fast shot!!! one billionth of a second?? that can't be right...)

@saimn saimn closed this in 06744c8 Mar 10, 2018

@saimn

This comment has been minimized.

Owner

saimn commented Mar 10, 2018

Ok, after some testing I think 0.7 works well so I added this, thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment