Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feeds plugin and Sigal in a subdirectory #361

Closed
jeekajoo opened this issue Feb 4, 2019 · 6 comments

Comments

@jeekajoo
Copy link

commented Feb 4, 2019

Hi,

  1. It looks like "feeds" plugin doesn't handle having Sigal in a subdirectory.
    In my case, Sigal is served in "pics/" and it's missing in all links of atom and rss feeds.

  2. And also, both feeds produce links to a-directory-in-sigal/#an-image.jpg instead of a-directory-in-sigal/an-image.jpg. Thumbnails URL are fine, except they are missing 1).

Thanks
J.

saimn added a commit that referenced this issue Feb 8, 2019
@saimn

This comment has been minimized.

Copy link
Owner

commented Feb 8, 2019

Hi, thanks for reporting.

  1. should be fixed by the commit above.
  2. this link is valid for the galleria theme, it allows to show the image in the galleria viewer. But the other themes it was indeed wrong, it should be fixed as well.
@saimn saimn closed this Feb 8, 2019
@saimn saimn added this to the 2.1 milestone Feb 8, 2019
@jeekajoo

This comment has been minimized.

Copy link
Author

commented Feb 10, 2019

Hi, thank you
Sorry but that ain't workin'. Demo : https://jeekajoo.eu/files/pics/

rss_feed = {'feed_url': 'https://jeekajoo.eu/files/pics/feed.rss', 'nb_items': 100}
atom_feed = {'feed_url': 'https://jeekajoo.eu/files/pics/feed.atom', 'nb_items': 100}
saimn added a commit that referenced this issue Feb 11, 2019
@saimn

This comment has been minimized.

Copy link
Owner

commented Feb 11, 2019

@jeekajoo - Ah yes, sorry, and thanks for testing. It should be better now.

@jeekajoo

This comment has been minimized.

Copy link
Author

commented Feb 11, 2019

It works (thumbnails appear correctly in the feed) but each feed item links to the folder in which it is stored :

Thank you

@saimn

This comment has been minimized.

Copy link
Owner

commented Feb 12, 2019

Yeah, there is no mean currently to link directly to a given image.

@jeekajoo

This comment has been minimized.

Copy link
Author

commented Feb 12, 2019

Ok if you say so, be it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.