Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the serve command #107

Closed
wants to merge 7 commits into from
Closed

Enhance the serve command #107

wants to merge 7 commits into from

Conversation

@vikramls
Copy link

@vikramls vikramls commented Sep 1, 2014

Hello,

Just started using sigal and loving it so far. While building my gallery, I saw that the build command only serves content from the _build directory only.

This change allows for the build directory to be read from the config (if available). Default is to use the path specified on the command-line.

@vikramls

This comment has been minimized.

Copy link
Owner

@vikramls vikramls commented on 29b8249 Sep 1, 2014

This is a git merge origin/master of the squash commit for the previous 5 commits
(3e49856)

Vikram Shirgur added 2 commits Sep 1, 2014
Write error to log when destination doesn't exist and config is not available.

Add self to AUTHORS.

Remove logging from serve command due to issues with running test_cli.
Add test-case for 'serve' command.

Add docs for the serve command.
@saimn
Copy link
Owner

@saimn saimn commented Sep 1, 2014

Thanks for the contribution ! Could you just wrap long lines to 80 characters ? Also it seems that you have an issue with your squashed commit as the previous commit are still there.

@vikramls
Copy link
Author

@vikramls vikramls commented Sep 2, 2014

Sure, will do. Need to figure out how to squash git commits cleanly.

@vikramls
Copy link
Author

@vikramls vikramls commented Sep 2, 2014

Just added a new commit fixing the long lines issue. Need to spend some more time improving my git-fu to remove the bad squash.

@vikramls vikramls changed the title Enhance the build command Enhance the serve command Sep 2, 2014
@vikramls
Copy link
Author

@vikramls vikramls commented Sep 3, 2014

@saimn, since the travis build passes, do you still need me to squash the commits?

saimn added a commit that referenced this pull request Sep 4, 2014
@saimn
Copy link
Owner

@saimn saimn commented Sep 4, 2014

@vikramls : I merged it manually (3f34057). Thanks for the contribution !

@saimn saimn closed this Sep 4, 2014
@saimn saimn modified the milestone: 0.9 Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants