Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to generate media pages #126

Merged
merged 2 commits into from Dec 6, 2014
Merged

Conversation

@jrstarke
Copy link
Contributor

@jrstarke jrstarke commented Oct 28, 2014

  • New optional parameter added to Writer.__init__ to specify
    the template file
  • modified version of colorbox theme created that supports
    generating media pages and linking to them (if javascript
    is not supported)
  • media_page plugin created that responds to the gallery_build
    signal, and generates pages for each media element based on
    the media.html template, including links to the next and
    previous image (if applicable)

This is a copy of Pull request #124, but on a new branch.

- New optional parameter added to `Writer.__init__` to specify
the template file
- modified version of colorbox theme created that supports
generating media pages and linking to them (if javascript
is not supported)
- `media_page` plugin created that responds to the `gallery_build`
signal, and generates pages for each media element based on
the media.html template, including links to the next and
previous image (if applicable)

filenames = [os.path.join(album.dst_path, media.filename)
for album in gallery.albums.values()
for media in album.medias]

This comment has been minimized.

@saimn

saimn Nov 23, 2014
Owner

This list is not used, should it be removed ?

@saimn
Copy link
Owner

@saimn saimn commented Nov 23, 2014

Hi @jrstarke ,
Thanks for your work on this, and sorry for the delay.
I would prefer if your "colorbox-pages" theme was merged in the colorbox theme, to avoid the cost of maintaining two similar themes. You could add a setting if you need to know if the "media_page" plugin is used in the index.html file.

@jrstarke
Copy link
Contributor Author

@jrstarke jrstarke commented Nov 23, 2014

Oh, that's a good idea. Ya, a flag totally makes sense. I'll see what I can do :)

saimn added a commit that referenced this pull request Dec 6, 2014
Added the ability to generate media pages
@saimn saimn merged commit ab9860b into saimn:master Dec 6, 2014
1 check passed
1 check passed
@saimn
continuous-integration/travis-ci The Travis CI build passed
Details
@saimn
Copy link
Owner

@saimn saimn commented Dec 6, 2014

Thanks Jamie !

@saimn saimn mentioned this pull request Dec 6, 2014
@saimn saimn modified the milestone: 0.9 Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants