Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid black thumbnails with fade-in videos #143

Merged
merged 4 commits into from Feb 24, 2015
Merged

Conversation

@jdn06
Copy link
Contributor

@jdn06 jdn06 commented Feb 9, 2015

No description provided.

@saimn
Copy link
Owner

@saimn saimn commented Feb 16, 2015

Hi @jdn06 ,
this could be useful indeed, but Travis is failing and after a quick look it is because the test video's duration is ~2 seconds and you use 2 seconds for the -ss parameter ...
I'm not sure what's the best option here:

  • extract duration from ffmpeg's output and check if it is > 2s
  • add a setting to customize the ss vaue.
@jdn06
Copy link
Contributor Author

@jdn06 jdn06 commented Feb 21, 2015

I chose to add a parameter with a default value of 0. As everybody doesn't have the same kind of fade-in, it seems more useful than a check of the length of the video.

@saimn
Copy link
Owner

@saimn saimn commented Feb 22, 2015

Thanks, but the tests still fails, could you check why ?

saimn added a commit that referenced this pull request Feb 24, 2015
Avoid black thumbnails with fade-in videos
@saimn saimn merged commit debd703 into saimn:master Feb 24, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saimn
Copy link
Owner

@saimn saimn commented Feb 24, 2015

Great, thanks !

@saimn saimn modified the milestone: 0.10 Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants