Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for mp4, manually tested, mp4 files transcoded and link… #159

Merged
merged 4 commits into from Jun 12, 2015

Conversation

@MPavleski
Copy link
Contributor

@MPavleski MPavleski commented May 24, 2015

…s correctly populated in html

…s correctly populated in html
@saimn
Copy link
Owner

@saimn saimn commented May 24, 2015

Thanks for this PR ! Could you add the video_format setting in the settings template (sigal/templates/sigal.conf.py) and add yourself to the AUTHORS file ? It would also be good to have a test for this, or to parametrize the tests in tests/test_video.py to run for both webm and mp4 (using http://pytest.org/latest/parametrize.html#parametrize).

…late (sigal/templates/sigal.conf.py), added myself to the AUTHORS file. Parametrized the tests/test_video.py tests to run both for webm & mp4.
@MPavleski
Copy link
Contributor Author

@MPavleski MPavleski commented May 26, 2015

Thank you for the good work saimn. Hope the PR is ok now.

@MPavleski
Copy link
Contributor Author

@MPavleski MPavleski commented May 26, 2015

I see the travis is failing (on my windows machine with ffmpeg it passes). I do not know it that ffmpeg supports mp4..

…p4 / mp3 encoding
@saimn
Copy link
Owner

@saimn saimn commented May 28, 2015

I have tested your pr and it doesn't work with your settings (-crf 23). I get this error (with ffmpeg version 2.6.3):

The encoder 'aac' is experimental but experimental codecs are not enabled, add '-strict -2' if you want to use it.

If I add -strict -2, then it is ok. Another option could be to use another audio encoder, -acodec libmp3lame for instance.I don't know what is the best default settings ?

@MPavleski
Copy link
Contributor Author

@MPavleski MPavleski commented May 31, 2015

I researched a bit and the safest option would be to go with -strict -2 which will use the internal encoder. Default installations usually have another encoder as well libvo_aacenc, but doc. says it is performing worse that the built-in one (the experimental).

@saimn
Copy link
Owner

@saimn saimn commented May 31, 2015

Ok thanks Miroslav, can you add this to the default options ?

…le encoding mp4 (needed with some ffmpeg / avconv configurations)
@MPavleski
Copy link
Contributor Author

@MPavleski MPavleski commented Jun 12, 2015

Hey I've added this while back .. is it still not good ?

saimn added a commit that referenced this pull request Jun 12, 2015
added support for mp4, manually tested, mp4 files transcoded and link…
@saimn saimn merged commit 5050ef0 into saimn:master Jun 12, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saimn
Copy link
Owner

@saimn saimn commented Jun 12, 2015

Hi Miroslav,
Github doesn't notify when you just add a commit, so I didn't see it ;)
Thanks for your work on this !

@muggenhor muggenhor mentioned this pull request Jul 3, 2015
@iemejia
Copy link

@iemejia iemejia commented Jul 3, 2015

Hi, sorry to comment in this already closed PR. This change is worth a new public version, it has been some time since the last release, and I think users can benefit of this feature (also me, since I am one of the users of the PIP based release (since I never arrived to make it work from the source code).

@saimn
Copy link
Owner

@saimn saimn commented Jul 16, 2015

Sorry for the late answer; I plan to make a new release since several weeks but time flies ... It will come sooner or later.

@saimn saimn modified the milestone: 0.10 Aug 31, 2015
kontza pushed a commit to kontza/sigal that referenced this pull request Aug 28, 2020
added support for mp4, manually tested, mp4 files transcoded and link…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.