New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the relative check in Windows which fails due invoking relati… #160

Merged
merged 2 commits into from May 28, 2015

Conversation

2 participants
@MPavleski
Contributor

MPavleski commented May 24, 2015

…ve path checking for directories on different drives

Fix for the relative check in Windows which fails due invoking relati…
…ve path checking for directories on different drives
try:
relative_check = os.path.relpath(settings['destination'],
settings['source']).startswith('..')
except:

This comment has been minimized.

@saimn

saimn May 24, 2015

Owner

Could you specify here the type of exception that must be catched and add a comment ?

saimn added a commit that referenced this pull request May 28, 2015

Merge pull request #160 from MPavleski/windows_relative_path_fix
Fix for the relative check in Windows which fails due invoking relati…

@saimn saimn merged commit 35b8b6d into saimn:master May 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saimn

This comment has been minimized.

Owner

saimn commented May 28, 2015

Thanks !

@MPavleski

This comment has been minimized.

Contributor

MPavleski commented May 28, 2015

Thank you for the excellent tool.

@saimn saimn modified the milestone: 0.10 Aug 31, 2015

@saimn saimn added the windows label Sep 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment