-
Notifications
You must be signed in to change notification settings - Fork 171
add a theme using photoswipe (http://photoswipe.com/). #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fcde537
to
e3f4713
Compare
It is really great to see a new theme coming to sigal, thanks @franek! I will try it soon. |
Thanks it is a basic theme. I am not a designer. It answers to my need. This theme depends on this PR #164 |
since the dependent PR #164 is already merged, are there any plans to merge this soon ? |
e3f4713
to
4925444
Compare
@iemejia I have rebased the PR but there is still work on html/css (responsive design). I don't know if I will have time to work on it in the next days. Do not hesitate to propose improvement :p |
It looks already good ! A few suggestions to improve the design (at least for me ;)) :
|
@saimn I have applied what you have suggested. There are still some little things to do (video, documentation). |
At the moment, Photoswipe does not support video. Is possible to release this theme without video support ?!? |
0381bf4
to
67f6271
Compare
Yes, if you can just mention this in the docs, then it is not a problem for me. |
8e8a225
to
4bff11d
Compare
done. Thx |
This is a wonderful contribution. Thank you @franek! I have used this new theme for a gallery I've posted: http://lukeandmichelle.ca/cycamatic/ I did some work to improve the alignment of the thumbnails and to ensure the layout is responsive to small screens. I posted my changes here. If they're a useful addition to this PR, I can submit a PR to this branch so that they are amalgamated. I tested these changes on Mac Chrome, Firefox, Safari, and Mobile Safari on iPhone 4S, and simulated a few other mobile devices using Chrome Devtools. |
Hi @lukecyca, Nice. Seems very good. You can submit a PR to this branch and I will check. Thx, |
Merged ! Thanks for your work on this, I guess it is time to bump a new version :) |
\o/ |
New version, new version, yeeesss please, pypi ! |
This PR is linked to #164
Photoswipe library needs image size to render image (see http://photoswipe.com/documentation/faq.html). So, I have to add a specific property to return image size (disclaimer : I am a python beginner). We can't use 'img_size' property because depending on image orientation, image size can differ.
The first image is highlighted for each album.
Pictures are lazy loaded thanks to echo (https://github.com/toddmotto/echo).
TODO