Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a theme using photoswipe (http://photoswipe.com/). #163

Merged
merged 1 commit into from Aug 6, 2015

Conversation

@franek
Copy link
Contributor

@franek franek commented Jun 11, 2015

This PR is linked to #164

Photoswipe library needs image size to render image (see http://photoswipe.com/documentation/faq.html). So, I have to add a specific property to return image size (disclaimer : I am a python beginner). We can't use 'img_size' property because depending on image orientation, image size can differ.

The first image is highlighted for each album.

Pictures are lazy loaded thanks to echo (https://github.com/toddmotto/echo).

TODO

  • improve CSS and HTML
  • improve responsive design
  • add support for video (not supported)
  • add support for albums
  • add links
  • update documentation
@franek franek force-pushed the franek:implement-photoswipe branch from fcde537 to e3f4713 Jun 12, 2015
@saimn
Copy link
Owner

@saimn saimn commented Jun 13, 2015

It is really great to see a new theme coming to sigal, thanks @franek! I will try it soon.

@franek
Copy link
Contributor Author

@franek franek commented Jun 14, 2015

Thanks it is a basic theme. I am not a designer. It answers to my need. This theme depends on this PR #164

@iemejia
Copy link

@iemejia iemejia commented Jul 3, 2015

since the dependent PR #164 is already merged, are there any plans to merge this soon ?

@franek franek force-pushed the franek:implement-photoswipe branch from e3f4713 to 4925444 Jul 3, 2015
@franek
Copy link
Contributor Author

@franek franek commented Jul 3, 2015

@iemejia I have rebased the PR but there is still work on html/css (responsive design). I don't know if I will have time to work on it in the next days. Do not hesitate to propose improvement :p

@saimn
Copy link
Owner

@saimn saimn commented Jul 17, 2015

It looks already good ! A few suggestions to improve the design (at least for me ;)) :

  • put the album-list and breadcrumb divs in the content div, so that these get aligned with the text below
  • remove the white border below the album-list
@franek
Copy link
Contributor Author

@franek franek commented Jul 23, 2015

@saimn I have applied what you have suggested. There are still some little things to do (video, documentation).

@franek
Copy link
Contributor Author

@franek franek commented Jul 23, 2015

At the moment, Photoswipe does not support video. Is possible to release this theme without video support ?!?

@franek franek force-pushed the franek:implement-photoswipe branch from 0381bf4 to 67f6271 Jul 23, 2015
@franek franek changed the title [WIP] add a theme using photoswipe (http://photoswipe.com/). add a theme using photoswipe (http://photoswipe.com/). Jul 23, 2015
@saimn
Copy link
Owner

@saimn saimn commented Jul 24, 2015

At the moment, Photoswipe does not support video. Is possible to release this theme without video support ?!?

Yes, if you can just mention this in the docs, then it is not a problem for me.

@franek franek force-pushed the franek:implement-photoswipe branch from 8e8a225 to 4bff11d Jul 25, 2015
@franek
Copy link
Contributor Author

@franek franek commented Jul 25, 2015

Yes, if you can just mention this in the docs, then it is not a problem for me.

done. Thx

@lukecyca
Copy link
Contributor

@lukecyca lukecyca commented Jul 28, 2015

This is a wonderful contribution. Thank you @franek!

I have used this new theme for a gallery I've posted: http://lukeandmichelle.ca/cycamatic/

I did some work to improve the alignment of the thumbnails and to ensure the layout is responsive to small screens. I posted my changes here. If they're a useful addition to this PR, I can submit a PR to this branch so that they are amalgamated.

I tested these changes on Mac Chrome, Firefox, Safari, and Mobile Safari on iPhone 4S, and simulated a few other mobile devices using Chrome Devtools.

@franek
Copy link
Contributor Author

@franek franek commented Jul 28, 2015

Hi @lukecyca,

Nice. Seems very good. You can submit a PR to this branch and I will check.

Thx,

@franek
Copy link
Contributor Author

@franek franek commented Jul 30, 2015

thanks @lukecyca, I have merged your contribution and fix an alignment problem for menu.

@saimn If you are OK with this theme, you can merge this PR. thanks.

@saimn saimn merged commit 02ac6cb into saimn:master Aug 6, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saimn
Copy link
Owner

@saimn saimn commented Aug 6, 2015

Merged ! Thanks for your work on this, I guess it is time to bump a new version :)

@franek
Copy link
Contributor Author

@franek franek commented Aug 6, 2015

\o/
I wanted to fix image path for photoswipe theme but you did it (see 1639154). Thx

@iemejia
Copy link

@iemejia iemejia commented Aug 8, 2015

New version, new version, yeeesss please, pypi !

@saimn saimn modified the milestone: 0.10 Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.