New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a first version of video support for photoswipe theme. #216

Merged
merged 1 commit into from Aug 24, 2016

Conversation

2 participants
@franek
Contributor

franek commented Aug 20, 2016

CSS position is not perfect. It can be improved.

Implementation is based upon this comment : dimsemenov/PhotoSwipe#651 (comment)

implement a first version of video support for photoswipe theme.
CSS position is not perfect. It can be improved.

Implementation is based upon this comment : dimsemenov/PhotoSwipe#651 (comment)
@saimn

This comment has been minimized.

Owner

saimn commented Aug 24, 2016

Thanks @franek , looks nice !
So, the only drawback is that it doesn't work with MS IE 11 and Edge 11 ?

@saimn saimn merged commit d758105 into saimn:master Aug 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@saimn saimn added this to the 1.3.0 milestone Aug 24, 2016

@franek

This comment has been minimized.

Contributor

franek commented Aug 25, 2016

I did not try with MS IE11 and Edge 11 but according github issue it seems.
I try on my old Android device and it seems that it does not work too. Need to investigate.
It works well on Chrome/Firefox Desktop.
Thanks for merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment