New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA and GTM updates #221

Merged
merged 5 commits into from Sep 28, 2016

Conversation

2 participants
@brentbb

brentbb commented Sep 27, 2016

Hi, I use Google Tag Manager on my site so I've added in support into the included templates.
Regards,
Brent

brent.bb added some commits Sep 27, 2016

brent.bb
Update Google Analytics UA Code (Fixes #182)
Refresh Google Analytics tracking JavaScript code from Google.
brent.bb
Add support for Google Tag Manager
Add support for Google Tag Manager tracking code into the included
themes and the configuration template.
@saimn

This comment has been minimized.

Owner

saimn commented Sep 27, 2016

Thanks @brentbb . It seems the new GA tracking code must be placed before the closing head, can you make the change ? Also please add yourself to the AUTHORS file :)

brent.bb added some commits Sep 27, 2016

brent.bb
Add default GTM config key
Add the key for GTM and blank default value into the DEFAULT_CONFIG
brent.bb
Move new GA code into the head tag
The new Google Analytics JavaScript is now placed at the end of the
HTML HEAD tag in the included themes.
brent.bb
Add self to AUTHORS
Add self as a contributor
@brentbb

This comment has been minimized.

brentbb commented Sep 28, 2016

Done and done, thanks @saimn.

@saimn saimn merged commit f294c3f into saimn:master Sep 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saimn

This comment has been minimized.

Owner

saimn commented Sep 28, 2016

Merged, thanks !

@saimn saimn added this to the 1.3.0 milestone Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment