Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA and GTM updates #221

Merged
merged 5 commits into from Sep 28, 2016
Merged

GA and GTM updates #221

merged 5 commits into from Sep 28, 2016

Conversation

@brentbb
Copy link

@brentbb brentbb commented Sep 27, 2016

Hi, I use Google Tag Manager on my site so I've added in support into the included templates.
Regards,
Brent

brent.bb added 2 commits Sep 27, 2016
Refresh Google Analytics tracking JavaScript code from Google.
Add support for Google Tag Manager tracking code into the included
themes and the configuration template.
@saimn
Copy link
Owner

@saimn saimn commented Sep 27, 2016

Thanks @brentbb . It seems the new GA tracking code must be placed before the closing head, can you make the change ? Also please add yourself to the AUTHORS file :)

brent.bb added 3 commits Sep 27, 2016
Add the key for GTM and blank default value into the DEFAULT_CONFIG
The new Google Analytics JavaScript is now placed at the end of the
HTML HEAD tag in the included themes.
Add self as a contributor
@brentbb
Copy link
Author

@brentbb brentbb commented Sep 28, 2016

Done and done, thanks @saimn.

@saimn saimn merged commit f294c3f into saimn:master Sep 28, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saimn
Copy link
Owner

@saimn saimn commented Sep 28, 2016

Merged, thanks !

@saimn saimn added this to the 1.3.0 milestone Sep 28, 2016
kontza pushed a commit to kontza/sigal that referenced this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants