New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CSP compatibility with colorbox theme #245

Merged
merged 2 commits into from Mar 11, 2017

Conversation

2 participants
@jasuarez
Contributor

jasuarez commented Mar 5, 2017

This fix for colorbox theme helps to improve CSP compatibility.

Main problem is that CSP makes harder to work with static inline code, which is used in the theme.

So basically we move that code to external files, and load it in the template.

This can be considered part of fix for issue #178, at least for colorbox theme. But I think this very same idea can be applied to the other themes.

jasuarez added some commits Mar 5, 2017

colorbox: remove an inline javascript
This was done for Galleria theme in commit 96d6623.
colorbox: move inline script code to its own file
Main purpose is to fix problems with Content Security Policy, that makes
difficult to work with inline code.

@saimn saimn merged commit 23d0ede into saimn:master Mar 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@saimn saimn added this to the 1.4.0 milestone Mar 11, 2017

@saimn

This comment has been minimized.

Owner

saimn commented Mar 11, 2017

Great, thanks @jasuarez !

@jasuarez jasuarez deleted the jasuarez:colorbox-csp branch Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment