Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for tweaking how thumbnails should be cropped #263

Merged
merged 1 commit into from Oct 10, 2017

Conversation

@3onyc
Copy link
Contributor

@3onyc 3onyc commented Oct 1, 2017

This pull request allows specifying the centering parameter of ImageOps.fit in the config file, allowing for tweaks to how thumbnails are cropped with thumb_fit = True.

This is the most basic way I could think of implementing this, there's probably a more elegant way, and I'll gladly change this based on suggestions.

@3onyc 3onyc force-pushed the 3onyc:feature-fit-centering branch 2 times, most recently from dfd2cf4 to d2f58da Oct 1, 2017
@saimn
Copy link
Owner

@saimn saimn commented Oct 8, 2017

Seems good, thanks ! Could you just add yourself to the AUTHORS file ?

@3onyc 3onyc force-pushed the 3onyc:feature-fit-centering branch from d2f58da to f32e4f1 Oct 10, 2017
@3onyc
Copy link
Contributor Author

@3onyc 3onyc commented Oct 10, 2017

Done

@saimn saimn added this to the 1.4 milestone Oct 10, 2017
@saimn saimn merged commit 2e9f0bd into saimn:master Oct 10, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saimn
Copy link
Owner

@saimn saimn commented Oct 10, 2017

Thanks !

kontza pushed a commit to kontza/sigal that referenced this pull request Aug 28, 2020
Add config option for tweaking how thumbnails should be cropped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants