New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: configurable file extensions #270

Merged
merged 1 commit into from Nov 8, 2017

Conversation

2 participants
@matelakat
Contributor

matelakat commented Nov 6, 2017

This change enables people to configure what file extensions should be
recognised as images and videos by setting:

img_extensions and video_extensions

fixes #269

@saimn

Just a minor nitpick

@@ -49,6 +49,9 @@
# show_map = False
# leaflet_provider = 'OpenStreetMap.Mapnik'
# File extensions that should be treated as images
# img_extensions = ['.jpg', '.jpeg', '.png', '.gif'],

This comment has been minimized.

@saimn

saimn Nov 6, 2017

Owner

Remove trailing comma

@saimn

This comment has been minimized.

Owner

saimn commented Nov 6, 2017

Not sure why I did not go this way before, probably to limit the number of settings, but I agree that it's the easiest solution to allow users to cope with unusual extensions.

Refactor: configurable file extensions
This change enables people to configure what file extensions should be
recognised as images and videos by setting:

`img_extensions` and `video_extensions`

@matelakat matelakat force-pushed the matelakat:make-extensions-configurable branch from 1d6d44f to 4f22c02 Nov 8, 2017

@matelakat

This comment has been minimized.

Contributor

matelakat commented Nov 8, 2017

Just a minor nitpick

Done @saimn

@saimn

saimn approved these changes Nov 8, 2017

@saimn

This comment has been minimized.

Owner

saimn commented Nov 8, 2017

Thanks @matelakat !

@saimn saimn merged commit 7e35d1f into saimn:master Nov 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment