Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: configurable file extensions #270

Merged
merged 1 commit into from Nov 8, 2017
Merged

Refactor: configurable file extensions #270

merged 1 commit into from Nov 8, 2017

Conversation

matelakat
Copy link
Contributor

This change enables people to configure what file extensions should be
recognised as images and videos by setting:

img_extensions and video_extensions

fixes #269

Copy link
Owner

@saimn saimn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick

@@ -49,6 +49,9 @@
# show_map = False
# leaflet_provider = 'OpenStreetMap.Mapnik'

# File extensions that should be treated as images
# img_extensions = ['.jpg', '.jpeg', '.png', '.gif'],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing comma

@saimn
Copy link
Owner

saimn commented Nov 6, 2017

Not sure why I did not go this way before, probably to limit the number of settings, but I agree that it's the easiest solution to allow users to cope with unusual extensions.

This change enables people to configure what file extensions should be
recognised as images and videos by setting:

`img_extensions` and `video_extensions`
@matelakat
Copy link
Contributor Author

Just a minor nitpick

Done @saimn

@saimn
Copy link
Owner

saimn commented Nov 8, 2017

Thanks @matelakat !

@saimn saimn merged commit 7e35d1f into saimn:master Nov 8, 2017
kontza pushed a commit to kontza/sigal that referenced this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: configurable video extensions
2 participants