New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorbox add site logo in sidebar #292

Closed
wants to merge 9 commits into
base: master
from

Conversation

2 participants
@brentbb

brentbb commented Feb 5, 2018

This is a port of a similar feature in Pelican that allows specifying a logo filename to replace the text of the gallery name in the sidebar.

@codecov

This comment has been minimized.

codecov bot commented Feb 5, 2018

Codecov Report

Merging #292 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files          19       19           
  Lines        1358     1358           
=======================================
  Hits         1188     1188           
  Misses        170      170
Impacted Files Coverage Δ
sigal/settings.py 96.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 244bc70...8bc6ddd. Read the comment docs.

@saimn saimn added this to the 1.4 milestone Feb 6, 2018

@saimn

This comment has been minimized.

Owner

saimn commented Feb 6, 2018

@brentbb - Thanks, it looks useful. However I think it would be better to put the logo by default in static/ directly (maybe not all themes have a images/ sub-directory) and btw avoid to hard-code images/ in the logo url.
Also it would great if you can squash your commits to remove the merge commits, and then you can add yourself to the AUTHORS file.

@saimn

This comment has been minimized.

Owner

saimn commented Feb 17, 2018

Merged manually (a102780), thanks!

@saimn saimn closed this Feb 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment