New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer loading of leaflet js til late in the page #298

Merged
merged 1 commit into from Feb 14, 2018

Conversation

2 participants
@edwinsteele
Contributor

edwinsteele commented Feb 14, 2018

This is the case for other javascript. Do it for leaflet too.

Defer loading of leaflet js til late in the page
This is the case for other javascript. Do it for leaflet too.
@codecov

This comment has been minimized.

codecov bot commented Feb 14, 2018

Codecov Report

Merging #298 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files          19       19           
  Lines        1358     1358           
=======================================
  Hits         1188     1188           
  Misses        170      170

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9004843...d3e5000. Read the comment docs.

@saimn

This comment has been minimized.

Owner

saimn commented Feb 14, 2018

Good idea, thanks!

@saimn saimn merged commit 00f96dc into saimn:master Feb 14, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 9004843...d3e5000
Details
codecov/project 87.48% remains the same compared to 9004843
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@saimn saimn added this to the 1.4 milestone Feb 17, 2018

@edwinsteele edwinsteele deleted the edwinsteele:move-leaflet-js-in-page branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment