New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compress_assets plugin #300

Merged
merged 3 commits into from Feb 16, 2018

Conversation

2 participants
@Glandos
Contributor

Glandos commented Feb 15, 2018

  • The plugin, based on every conversation in #288
  • Configuration
  • Myself as author
  • Docs
  • Tests
  • Dependencies for Travis
Add compress_assets plugin:
- The plugin
- Configuration
- Myself as author
- Docs
- Tests
- Dependencies for Travis

@Glandos Glandos referenced this pull request Feb 15, 2018

Closed

Add compress assets plugin #288

@codecov

This comment has been minimized.

codecov bot commented Feb 15, 2018

Codecov Report

Merging #300 into master will increase coverage by 0.24%.
The diff coverage is 91.86%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #300      +/-   ##
=========================================
+ Coverage   87.65%   87.9%   +0.24%     
=========================================
  Files          19      20       +1     
  Lines        1377    1463      +86     
=========================================
+ Hits         1207    1286      +79     
- Misses        170     177       +7
Impacted Files Coverage Δ
sigal/plugins/compress_assets.py 91.86% <91.86%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cdb22...28ce821. Read the comment docs.

@Glandos

This comment has been minimized.

Contributor

Glandos commented Feb 15, 2018

I still don't understand why there is no coverage reported for brotli and zopfli. The code is tested with pytest…

@saimn

This comment has been minimized.

Owner

saimn commented Feb 15, 2018

Thanks @Glandos ! From #288 I think it just misses the merging of the progress bars, not critical but it would be good to have this. I'm looking into the coverage issue.

def test_compress(settings, tmpdir, method, compress_suffix, test_import):
if test_import:
pytest.importorskip(test_import)
compress_options = make_gallery(settings, tmpdir, 'gzip')

This comment has been minimized.

@saimn

saimn Feb 15, 2018

Owner

So other methods are not tested because 'gzip' is always used here instead of method 😅

This comment has been minimized.

@Glandos

Glandos Feb 16, 2018

Contributor

Ahah. You're right. This happens when it's too late to code.

Use parameters for parametrized test
Instead of hardcoded values…
@Glandos

This comment has been minimized.

Contributor

Glandos commented Feb 16, 2018

You're right, I thought about the progress bars only after a good night. I won't edit this through GitHub though, I need to test this on my development environment.

@saimn saimn merged commit 3d2c6f0 into saimn:master Feb 16, 2018

3 checks passed

codecov/patch 91.86% of diff hit (target 87.65%)
Details
codecov/project 87.9% (+0.24%) compared to c2cdb22
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saimn

This comment has been minimized.

Owner

saimn commented Feb 16, 2018

Thanks!

@saimn saimn added this to the 1.4 milestone Feb 17, 2018

@Glandos Glandos deleted the Glandos:compress_assets_plugin branch Feb 18, 2018

@saimn saimn referenced this pull request Mar 7, 2018

Merged

Drop Python 2 support #309

@anarcat anarcat referenced this pull request Mar 12, 2018

Open

Debian packaging #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment