Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Galleria theme now reads image data from json #312
Having the template generate json makes it sensitive to whitespace, particularly in the description field, where failure means the gallery doesn’t load (errors in the js console). I’ve looked at ~20 galleries of mine without problems, though.
DOM interactive and document complete are noticeably improved with this change, though the first main image of the gallery is still completing its load at about the same time. To be fair the improvement will likely be more stark on a bigger gallery.
@@ Coverage Diff @@ ## master #312 +/- ## ========================================== - Coverage 87.9% 87.28% -0.62% ========================================== Files 20 19 -1 Lines 1463 1408 -55 ========================================== - Hits 1286 1229 -57 - Misses 177 179 +2