Skip to content

Quote special characters in urls #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2018
Merged

Quote special characters in urls #345

merged 5 commits into from
Oct 10, 2018

Conversation

saimn
Copy link
Owner

@saimn saimn commented Oct 4, 2018

This is a quick and untested rebase of an old commit. Needs some testing.

@saimn
Copy link
Owner Author

saimn commented Oct 4, 2018

@alcoralcor - Do you think that you could test with this branch ? It would really useful.

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #345 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage    87.4%   87.47%   +0.07%     
==========================================
  Files          19       19              
  Lines        1421     1429       +8     
==========================================
+ Hits         1242     1250       +8     
  Misses        179      179
Impacted Files Coverage Δ
sigal/utils.py 90.9% <100%> (+0.16%) ⬆️
sigal/gallery.py 89.01% <100%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e8cb8...8fc30e7. Read the comment docs.

@alcoralcor
Copy link

I've done some tests.
In "<img src=...", only file name is encoded. Path isn't. So, thumbnails are not loaded into page when there's a special char in path. They are loaded in last directory level because there are no more path, except "thumbnails/".
Lots of special chars have been used, all are well encoded when they are ... (in "<a href=" or file names as mentioned above).
I've tested this in all themes (galleria, colorbox and photoswipe). I'm running Python 3.6.6.

@saimn
Copy link
Owner Author

saimn commented Oct 8, 2018

Thanks for the testing @alcoralcor , hopefully it should be good now!

@alcoralcor
Copy link

Everything's working properly now @saimn ! Thank you for the fix !

@saimn saimn added this to the 2.0 milestone Oct 10, 2018
@saimn saimn merged commit 8b38f32 into master Oct 10, 2018
@saimn saimn deleted the special-chars branch October 10, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants