New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise galleria templates #347

merged 3 commits into from Oct 10, 2018


2 participants
Copy link

edwinsteele commented Oct 10, 2018

This will be easier to review by commit, rather than by file.

Logic split into base, album and album_list.
Footer is now shared with the colorbox theme.
When on the album_list page, prefetch the JS and CSS that the album page will use, thus improving load times for the albums.

With the exception of the prefetch directives (and a few small whitespace changes), the pages are before and after this PR are identical.


This comment has been minimized.

Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #347   +/-   ##
  Coverage    87.4%   87.4%           
  Files          19      19           
  Lines        1421    1421           
  Hits         1242    1242           
  Misses        179     179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676badd...3607d60. Read the comment docs.

@saimn saimn merged commit 00e8cb8 into saimn:master Oct 10, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 676badd...3607d60
codecov/project 87.4% remains the same compared to 676badd
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

Copy link

saimn commented Oct 10, 2018

Thanks Edwin!

@saimn saimn added this to the 2.0 milestone Oct 10, 2018

This was referenced Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment