New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract IPTC Headline #356

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
2 participants
@tudacs
Copy link
Contributor

tudacs commented Dec 18, 2018

As noted in the commit message, IPTC Headline (2:105) is the right field for a synopsis of the description, see also the iptc standard.

This pr adds the extraction of the Headline-field to get_iptc_data().

Add IPTC Headline (2:105) and to iptc_data
According to iptc.org, the 'title' field (2:05) is "a shorthand
reference for the digital image" and may (User Note) be the filename,
whereas the IPTC Headline is defined as "A brief synopsis of the
caption.".

Thus the headline should be used by sigal to provide a short
description, instead of the title tag.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #356 into master will decrease coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   87.47%   87.42%   -0.06%     
==========================================
  Files          19       19              
  Lines        1429     1431       +2     
==========================================
+ Hits         1250     1251       +1     
- Misses        179      180       +1
Impacted Files Coverage Δ
sigal/image.py 91.48% <50%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0b8d9...7b10911. Read the comment docs.

@tudacs tudacs force-pushed the tudacs:iptc_headline branch from 5af250b to 7b10911 Dec 18, 2018

@saimn saimn merged commit c45d6e8 into saimn:master Dec 18, 2018

1 of 3 checks passed

codecov/patch 50% of diff hit (target 87.47%)
Details
codecov/project 87.42% (-0.06%) compared to 1c0b8d9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saimn

This comment has been minimized.

Copy link
Owner

saimn commented Dec 18, 2018

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment