Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for relative symbolic links. #359

Merged
merged 4 commits into from Feb 1, 2019

Conversation

@maauer
Copy link

commented Jan 31, 2019

This commit uses the code from and solves issue #333.

max (maauer) added 2 commits Jan 31, 2019
Edit the copy function in utils.py to take the parameter rellink and if
it is true, create links relative to the source directory. Modify
gallery.py and __init__.py to pass along this parameter. Add rel_link
flag to setting.py
@codecov

This comment has been minimized.

Copy link

commented Jan 31, 2019

Codecov Report

Merging #359 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   87.39%   87.34%   -0.06%     
==========================================
  Files          18       18              
  Lines        1436     1438       +2     
==========================================
+ Hits         1255     1256       +1     
- Misses        181      182       +1
Impacted Files Coverage Δ
sigal/settings.py 97.87% <ø> (ø) ⬆️
sigal/gallery.py 89.04% <100%> (ø) ⬆️
sigal/__init__.py 86% <100%> (ø) ⬆️
sigal/utils.py 91.22% <100%> (+0.31%) ⬆️
sigal/plugins/watermark.py 86.04% <0%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9ffd9...f2f6fbe. Read the comment docs.

@saimn

This comment has been minimized.

Copy link
Owner

commented Jan 31, 2019

Thanks! Could you add a test ? There is a test_copy function in test_utils.py.

max (maauer)
@maauer

This comment has been minimized.

Copy link
Author

commented Feb 1, 2019

I did not realize that pushing would automatically add my commit. I am fixing it.

max (maauer)
@saimn saimn added this to the 2.1 milestone Feb 1, 2019
@saimn saimn merged commit 3808bcf into saimn:master Feb 1, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 87.39%)
Details
codecov/project Absolute coverage decreased by -0.05% but relative coverage increased by +12.6% compared to 2e9ffd9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saimn

This comment has been minimized.

Copy link
Owner

commented Feb 1, 2019

Thanks!

saimn added a commit that referenced this pull request Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.